Skip to content

Conversation

@kridai
Copy link
Contributor

@kridai kridai commented Nov 4, 2025

Fixes

Add patch operation support for all languages. This change requires changes in respective files as well. This is the linked PR twilio/twilio-java#918 for base Patcher class

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • Run make test-docker
  • Verify affected language:
    • Generate twilio-go from our OpenAPI specification using the build_twilio_go.py using python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go and inspect the diff
    • Run make test in twilio-go
    • Create a pull request in twilio-go
    • Provide a link below to the pull request
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

@manisha1997
Copy link
Contributor

You can run make generate to show changes in all files.

Base automatically changed from twilio-java-generation-modernisation to main November 12, 2025 13:56
@tiwarishubham635 tiwarishubham635 changed the base branch from main to twilio-java-generation-modernisation November 19, 2025 10:48
<!--
We appreciate the effort for this pull request but before that please
make sure you read the contribution guidelines, then fill out the blanks
below.

Please format the PR title appropriately based on the type of change:
  <type>[!]: <description>
Where <type> is one of: docs, chore, feat, fix, test, misc.
Add a '!' after the type for breaking changes (e.g. feat!: new breaking
feature).

**All third-party contributors acknowledge that any contributions they
provide will be made under the same open-source license that the
open-source project is provided under.**

Please enter each Issue number you are resolving in your PR after one of
the following words [Fixes, Closes, Resolves]. This will auto-link these
issues and close them when this PR is merged!
e.g.
Fixes #1
Closes #2
-->

# Fixes
[DII-2099](https://twilio-engineering.atlassian.net/browse/DII-2099)

Adding support for multiple update operations - update and patch in PHP

### Checklist
- [x] I acknowledge that all my contributions will be made under the
project's license
- [ ] Run `make test-docker`
- [ ] Verify affected language according to the code change:
- [ ] Generate [twilio-java](https://github.com/twilio/twilio-java) from
our [OpenAPI specification](https://github.com/twilio/twilio-oai) using
the [scripts/build_twilio_library.py](./scripts/build_twilio_library.py)
using `python scripts/build_twilio_library.py
path/to/twilio-oai/spec/yaml path/to/twilio-java -l java` and inspect
the diff
    - [ ] Run `make test` in `twilio-java`
    - [ ] Create a pull request in `twilio-java`
- [ ] Provide a link below to the pull request, this ensures that the
generated code has been verified
- [ ] I have made a material change to the repo (functionality, testing,
spelling, grammar)
- [ ] I have read the [Contribution
Guidelines](https://github.com/twilio/twilio-oai-generator/blob/main/CONTRIBUTING.md)
and my PR follows them
- [ ] I have titled the PR appropriately
- [ ] I have updated my branch with the main branch
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have added the necessary documentation about the functionality
in the appropriate .md file
- [ ] I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.
Base automatically changed from twilio-java-generation-modernisation to main November 24, 2025 06:15
@kridai kridai force-pushed the patch-operation-support branch from e921d62 to a8ec87b Compare November 24, 2025 10:56
@tiwarishubham635 tiwarishubham635 changed the base branch from main to twilio_api_standards_changes November 25, 2025 06:22
@kridai kridai changed the title [twilio-java] add patch operation support patch operation support Dec 4, 2025
kridai and others added 7 commits December 4, 2025 12:28
<!--
We appreciate the effort for this pull request but before that please
make sure you read the contribution guidelines, then fill out the blanks
below.

Please format the PR title appropriately based on the type of change:
  <type>[!]: <description>
Where <type> is one of: docs, chore, feat, fix, test, misc.
Add a '!' after the type for breaking changes (e.g. feat!: new breaking
feature).

**All third-party contributors acknowledge that any contributions they
provide will be made under the same open-source license that the
open-source project is provided under.**

Please enter each Issue number you are resolving in your PR after one of
the following words [Fixes, Closes, Resolves]. This will auto-link these
issues and close them when this PR is merged!
e.g.
Fixes #1
Closes #2
-->

# Fixes #

Some typo change

### Checklist
- [x] I acknowledge that all my contributions will be made under the
project's license
- [ ] Run `make test-docker`
- [ ] Verify affected language according to the code change:
- [ ] Generate [twilio-java](https://github.com/twilio/twilio-java) from
our [OpenAPI specification](https://github.com/twilio/twilio-oai) using
the [scripts/build_twilio_library.py](./scripts/build_twilio_library.py)
using `python scripts/build_twilio_library.py
path/to/twilio-oai/spec/yaml path/to/twilio-java -l java` and inspect
the diff
    - [ ] Run `make test` in `twilio-java`
    - [ ] Create a pull request in `twilio-java`
- [ ] Provide a link below to the pull request, this ensures that the
generated code has been verified
- [ ] I have made a material change to the repo (functionality, testing,
spelling, grammar)
- [ ] I have read the [Contribution
Guidelines](https://github.com/twilio/twilio-oai-generator/blob/main/CONTRIBUTING.md)
and my PR follows them
- [ ] I have titled the PR appropriately
- [ ] I have updated my branch with the main branch
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have added the necessary documentation about the functionality
in the appropriate .md file
- [ ] I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.
@kridai kridai merged commit f8cfa59 into twilio_api_standards_changes Jan 22, 2026
9 checks passed
@kridai kridai deleted the patch-operation-support branch January 22, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants